Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-06 Thread Reid Kleckner via cfe-commits
rnk added a comment. In http://reviews.llvm.org/D11437#211165, @chh wrote: > I tried to make X86_64ABIInfo::classify to return (Lo=SSE, Hi=NoClass) for > fp128 long double type, or (Lo=SSE, Hi=SSEUp). That is not enough, although > making fp128 Complex type to "Memory" worked. > > X86_64ABIInfo

Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-06 Thread Reid Kleckner via cfe-commits
rnk commandeered this revision. rnk added a reviewer: chh. rnk added a comment. Comandeering so I can upload my diff. http://reviews.llvm.org/D11437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-06 Thread Reid Kleckner via cfe-commits
rnk updated this revision to Diff 31457. rnk updated the summary for this revision. rnk added a comment. - Update classify and GetByteVectorType http://reviews.llvm.org/D11437 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_64-fp128.c Index: test/CodeGen/x86_64-fp128.c =

Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-06 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. Reid, thanks a lot for fixing my hacks! I tried your new diff 31457 and it worked for Android libm and all my other tests. I am still waiting for some review of the back end changes in http://reviews.llvm.org/D11438. This patch can be submitted now or later with http://revi

Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-10 Thread Chih-Hung Hsieh via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244468: Correct x86_64 fp128 calling convention (authored by chh). Changed prior to commit: http://reviews.llvm.org/D11437?vs=31457&id=31687#toc Repository: rL LLVM http://reviews.llvm.org/D11437 F