[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 406351. skc7 added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/Analysis/InstSimplifyFolder.h llvm/in

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 391836. skc7 added a comment. updated test IR files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/Analysis/TargetFolder.h

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

loladiro added a comment. @jrtc27 is correct. This absolutely must not apply to non-integral address spaces. It is not legal for LLVM to introduce additional ptrtoint instructions for non-integral address spaces that were not present in the original input IR. That doesn't change if the spelling

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 389983. skc7 added a comment. Updated diff with changes suggested by jrtc27 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. In D114533#3154225 , @arsenm wrote: > In D114533#3153924 , @jrtc27 wrote: > >> This seems like it should not apply to non-integral address spaces? > > No, it shouldn’t care about the indivi

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3153924 , @jrtc27 wrote: > This seems like it should not apply to non-integral address spaces? No, it shouldn’t care about the individual address spaces. It’s a reinterpret of the bits, the type meanings don’t matter

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. This seems like it should not apply to non-integral address spaces? Comment at: llvm/docs/LangRef.rst:10999 +with this instruction. Conversion of pointers to different address spaces +are legal, but may result in undefined behaviour where such a reinter

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3151482 , @lebedev.ri wrote: > In D114533#3151423 , @arsenm wrote: > >> Patch description should include this avoids a need to introduce >> ptrtoint/inttoptr pairs > > That is

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. In D114533#3151423 , @arsenm wrote: > Patch description should include this avoids a need to introduce > ptrtoint/inttoptr pairs That is a good point, but all the motivational cases seem to be about chaining the address spac

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. Patch description should include this avoids a need to introduce ptrtoint/inttoptr pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 __

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. Is there an RFC? This quite seems like asking for problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 ___ cfe-commits mailing

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 created this revision. skc7 added reviewers: sameerds, arsenm. Herald added subscribers: dexonsmith, lxfind, jdoerfert, zzheng, hiraditya. skc7 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang, LLVM. When the addrspacec