[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau closed this revision. MattDevereau added a comment. 41def32040787e917b52279cc30231b27f2f02f7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://revie

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM once D115259 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ htt

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau marked an inline comment as done. MattDevereau added a comment. clang-format is upset about this ordering: #include "clang/Basic/arm_sve_builtin_cg.inc" #include "clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def" but swapping the order causes all SVE tests to fail. I'm ignoring the

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 392015. MattDevereau added a comment. replace numbers in BuiltinsAArch64NeonSVEBridge_cg.def with SVETypeFlags enum values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.or

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391616. MattDevereau added a comment. run clang format to fix test macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/clang/Basic/Built

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391595. MattDevereau added a comment. updated SVEMAP2 types added overloadable intrinsics updated BUILTIN function signatures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/cla

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau marked an inline comment as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); }

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def:37 +SVEMAP2(svdup_neonq_f64, 3), +SVEMAP2(svdup_neonq_bf16, 1), +#endif The second argument is a 'flags' field and these values don't look right. Ref

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } MattDevereau wrote: > paulwalker-arm wro

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 390731. MattDevereau added a comment. updated builtin signatures in `clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge.def` removed irrelevant change in `llvm/lib/Target/AArch64/AArch64ISelLowering.cpp` ran clang-format CHANGES SINCE LAST ACTION

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } paulwalker-arm wrote: > Can you extract th

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge.def:2 +#ifdef GET_SVE_BUILTINS +BUILTIN(__builtin_sve_svget_neonq_s8, "q4iq16bq4i", "n") +BUILTIN(__builtin_sve_svget_neonq_s16, "q4iq16bq4i", "n") Looks lik

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64_neon_sve_bridge_intrinsics/acle_neon_sve_bridge_dup_neonq.c:8 + +#define SVE_ACLE_FUNC(A1,A2,A3,A4) A1##A2##A3##A4 + Do you also want to test the overloaded forms here via SVE_OVERLOAD

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } Can you extract this into its own patch

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau created this revision. MattDevereau added reviewers: bsmith, peterwaller-arm, DavidTruby, paulwalker-arm. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett, mgorny. Herald added a reviewer: efriedma. MattDevereau requested review of this revision. Herald added proje