[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115225/new/ https://reviews.llvm.org/D115225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7c07f60b35f: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11522

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115225/new/ https://reviews.llvm.org/D115225 ___ cfe

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:42 __asm mov eax, k; - // CHECK: movl_k, %eax + // CHECK: movlk, %eax __asm mov eax, kptr; skan wrote: > This change is strange here. Others looks good to me.

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:42 __asm mov eax, k; - // CHECK: movl_k, %eax + // CHECK: movlk, %eax __asm mov eax, kptr; This change is strange here. Others looks good to me. Repository: r

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei created this revision. pengfei added reviewers: skan, xiangzhangllvm, craig.topper, coby. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D113096