This revision was automatically updated to reflect the committed changes.
Closed by commit rG3110060bc721: AST: Avoid using SmallVector::set_size() in
UnresolvedSet (authored by dexonsmith).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115386/new/
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: clang/lib/Sema/SemaLookup.cpp:623
- Decls.set_size(N);
+ Decls.truncate(N);
dexonsmith wrote:
> Two things to confirm here.
dexonsmith added inline comments.
Comment at: clang/lib/Sema/SemaLookup.cpp:623
- Decls.set_size(N);
+ Decls.truncate(N);
Two things to confirm here.
First is that the destructors are trivial. From
clang/include/clang/AST/DeclAccessPair.h:
```
lang=c++
cl
dexonsmith updated this revision to Diff 392977.
dexonsmith added reviewers: Bigcheese, jansvoboda11, vsapsai.
dexonsmith added a comment.
Adding a couple of other possible reviewers.
[no change, just retriggering bots after spurious failure]
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
dexonsmith created this revision.
dexonsmith added a reviewer: dblaikie.
dexonsmith requested review of this revision.
Herald added a project: clang.
Update UnresolvedSet to use (and expose) `SmallVector::truncate()` instead
of `SmallVector::set_size()`. The latter is going to made private in a
fu
