[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. In D115409#3190589 , @jyknight wrote: > OK, I do think that special case definitely needs to be deleted. It's > assuming that the block args are in a particular place in the

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23 +; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1 +; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch nickdesaulniers wrote: > @craig.topper can you triple

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

jyknight added a comment. OK, I do think that special case definitely needs to be deleted. It's assuming that the block args are in a particular place in the argument list of the callbr -- the place Clang put them -- and then assigned special behavior based on that location. But I think it

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23 +; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1 +; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch @craig.topper can you triple check this change to

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392994. nickdesaulniers added a comment. - phab sux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115409/new/ https://reviews.llvm.org/D115409 Files:

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers updated this revision to Diff 392988. nickdesaulniers added a comment. Herald added subscribers: cfe-commits, wenlei, asbirlea, zzheng, kbarton, nemanjai. Herald added a project: clang. - I'm just wrestling with arc at this point Repository: rG LLVM Github Monorepo CHANGES