This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd3606a3375d2: [clangd] Provide documentation as
MarkupContent in signaturehelp (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGE
kadircet updated this revision to Diff 393438.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Drop extra tests
- Move capability closer to others
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115442/new/
https://reviews.llvm
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
MarkupContent was introduced in 3.12 in 2018.
We could continue to support older clients by rendering plaintext as string
instead of the MarkupContent struct but it doesn't seem worth it.
kadircet added a comment.
Also some related discussions in https://github.com/clangd/clangd/issues/945
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115442/new/
https://reviews.llvm.org/D115442
___
cfe-c
kadircet added a comment.
I am thinking about a follow-up which will actually change
`formatDocumentation` to return a `Markup::Document` instead to make sure we
will have a single way of representing documents throughout features in future.
But that's also what we store in the index, hence will
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This unifies the behaviour we h
