[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2022-01-11 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c562f62a4ee: [clang] number labels in asm goto strings after tied inputs (authored by nickdesaulniers). Changed prior to commit:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-21 Thread Bill Wendling via Phabricator via cfe-commits
void accepted this revision. void added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/LanguageExtensions.rst:1474 +When using tied-outputs (ie. outputs that are inputs and outputs, not just +outputs) with the `+r` constraint, there is

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-14 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 394415. nickdesaulniers added a comment. - rebase onto D115688 +D115410 +D115311 , add notes to clang/docs/LanguageExtensions.rst Repository:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-13 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:157 ABI stability. +- When using ``asm goto`` with outputs whose constraint modifier is ``"+"``, we + now change the numbering of the labels to occur after hidden tied inputs for

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-11 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:157 ABI stability. +- When using ``asm goto`` with outputs whose constraint modifier is ``"+"``, we + now change the numbering of the labels to occur after hidden tied inputs for there

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 393630. nickdesaulniers added a comment. - fix typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ https://reviews.llvm.org/D115471 Files: clang/docs/ReleaseNotes.rst

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 393577. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - note this semantic change in the release notes, add links to GCC docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-09 Thread Andrew Pinski via Phabricator via cfe-commits
apinski-cavium added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98096 GCC even documents it this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ https://reviews.llvm.org/D115471

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D115471#3184384 , @jyknight wrote: > It's rather sad that GCC made the quite-unintuitive decision to number the > arguments in this way -- LONG AFTER clang had already implemented the other > way... I doubt it was

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-09 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. It's rather sad that GCC made the quite-unintuitive decision to number the arguments in this way -- LONG AFTER clang had already implemented the other way... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

2021-12-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: void, efriedma, jyknight, craig.topper. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that the following case would compile in Clang but