This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3ad35ba4dea5: [Templight] Don't display empty strings
for names of unnamed template parameters (authored by Szelethus).
Changed prior to commit:
h
martong accepted this revision.
martong added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115521/new/
https://reviews.llvm.org/D115521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
Szelethus added inline comments.
Comment at: clang/lib/Frontend/FrontendActions.cpp:501
+
+if (const auto *Decl = dyn_cast(NamedTemplate)) {
+ if (const auto *R = dyn_cast(Decl)) {
Szelethus wrote:
> martong wrote:
> > martong wrote:
> > > Should this ha
martong added inline comments.
Comment at: clang/lib/Frontend/FrontendActions.cpp:501
+
+if (const auto *Decl = dyn_cast(NamedTemplate)) {
+ if (const auto *R = dyn_cast(Decl)) {
martong wrote:
> Should this handle `EnumDecl`s as well? An enum declaratio
Szelethus updated this revision to Diff 397054.
Szelethus added a comment.
Add a default text, if another, unhandled unnamed identifier pops up.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115521/new/
https://reviews.llvm.org/D115521
Files:
clang/lib/Frontend/FrontendActions.cpp
sabel83 added inline comments.
Comment at: clang/lib/Frontend/FrontendActions.cpp:554
+
+llvm_unreachable("Failed to retrieve a name for this entry!");
+ }
Have you considered generating some default text here?
In case a new, uncovered case does not get cov
