This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d37d0ea3485: [Support] Expand `CFGDIR` as the base
directory in configuration files. (authored by jackoalan).
Repository:
rG LLVM Github
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115604/new/
https://reviews.llvm.org/D115604
jackoalan added a comment.
Actually, I just thought of a possible limitation of using path-append when
suffixing with something that isn't actually a path component. However, I
cannot say how critical this limitation is.
-Wl,-rpath,,foo.o
This will cause a trailing `/` to be inserted after
jackoalan updated this revision to Diff 396670.
jackoalan added a comment.
Add ReadConfigFile test case for multiple `` in one arg.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115604/new/
https://reviews.llvm.org/D115604
Files:
jackoalan marked an inline comment as done.
jackoalan added inline comments.
Comment at: llvm/lib/Support/CommandLine.cpp:1099
+else
+ llvm::sys::path::append(ResponseFile, LHS);
+ResponseFile.append(BasePath);
sepavloff wrote:
> What happens if ``
jackoalan updated this revision to Diff 396667.
jackoalan marked 5 inline comments as done.
jackoalan added a comment.
Update ReadConfigFile test with additional `` expansion contexts
(non-prefixed, non-suffixed, escaped in middle).
CHANGES SINCE LAST ACTION
sepavloff added inline comments.
Comment at: llvm/lib/Support/CommandLine.cpp:1099
+else
+ llvm::sys::path::append(ResponseFile, LHS);
+ResponseFile.append(BasePath);
What happens if `` is used without trailing path? Such line:
```
--sysroot=
jackoalan updated this revision to Diff 396576.
jackoalan added a comment.
Update call parameters in `ExpandResponseFilesDatabase::expand`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115604/new/
https://reviews.llvm.org/D115604
Files:
jackoalan updated this revision to Diff 396561.
jackoalan retitled this revision from "[Support] Expand `` as the base
directory in response files." to "[Support] Expand `` as the base
directory in configuration files.".
jackoalan added a comment.
Make `` constant at point of expansion. Use
