[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true; I

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I tested this on the original code that made me make the original change, and I like your fix much better ;-) Thank you for this patch, interested on working on other C# clang-format issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread Peter Stys via Phabricator via cfe-commits
peterstys updated this revision to Diff 394299. peterstys added a comment. Applied clang-formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

2021-12-14 Thread Peter Stys via Phabricator via cfe-commits
peterstys created this revision. peterstys added a reviewer: MyDeveloperDay. peterstys requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The alignment fix introduced by https://reviews.llvm.org/D104388 caused a regression whereby formatting