[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63a565768e8f: [clang-format] Remove spurious JSON binding when DisableFormat = true (authored by Andrew-William-Smith, committed by

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith added a comment. I'm going to assume that I don't have commit access to `main`, so that would be much appreciated. - Name: Andrew Smith - Email: aws awsmith us Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith updated this revision to Diff 394584. Andrew-William-Smith added a comment. Apologies, I undid the actual changes to `ClangFormat.cpp`. Still learning how to use `arc`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. looks like you reverted the change https://reviews.llvm.org/D115769?vs=394414=394582#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. I think your previous change is dropped from the review, but the test in combination with your original change were good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith updated this revision to Diff 394582. Andrew-William-Smith added a comment. Added a test with formatting disabled. I had to port the updated logic from `ClangFormat.cpp` into `FormatTestJson::format` to show the desired effect; I also couldn't call `verifyFormat` as-is

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. The following will show the issue TEST_F(FormatTestJson, DisableJsonFormat) { FormatStyle Style = getLLVMStyle(FormatStyle::LK_Json); verifyFormat("{}", Style); verifyFormat("{\n" " \"name\": 1\n" "}",

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. Thank you for the patch, this looks good but we do need a unit test in `clang/unittest/Format/FormatTestJson.cpp` you can then build them with `ninja FormatTests`, if you need help let me know Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

owenpan added a reviewer: owenpan. owenpan added a comment. Can you add a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 ___ cfe-commits mailing

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith created this revision. Andrew-William-Smith added reviewers: MyDeveloperDay, HazardyKnusperkeks, jbcoe. Andrew-William-Smith edited the summary of this revision. Andrew-William-Smith added a project: clang-format. Andrew-William-Smith retitled this revision from