[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e97db89ae8e: [PowerPC] Emit IR module flag for current float abi (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D116016?vs=530843&id=557298#toc Repository: rG LLVM Github Mon

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for reviving this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 __

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf added a comment. Gentle ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 530843. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf removed a reviewer: jsji. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 397443. qiucf added a comment. Only emit the flags when any instance of `long double` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 Files: clang/lib/CodeGe

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

MaskRay added a comment. In D116016#3203005 , @nemanjai wrote: > We should not be emitting the attribute in modules that do not have any use > of `long double`. Right, otherwise it would be a bit unfortunate that a library not using long double has to

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

nemanjai added a comment. We should not be emitting the attribute in modules that do not have any use of `long double`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 ___

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf added a comment. In D116016#3202148 , @MaskRay wrote: >> This is part of the efforts adding .gnu_attribute support for PowerPC. In >> Clang, an extra metadata field will be added as float-abi to show current >> long double format. So backend can e

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

MaskRay added a comment. > This is part of the efforts adding .gnu_attribute support for PowerPC. In > Clang, an extra metadata field will be added as float-abi to show current > long double format. So backend can emit .gnu_attribute section data from this > metadata. How does .gnu_attribute w

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, shchenz, PowerPC, uweigand, MaskRay. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a proj