[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG782791ee84d2: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling (authored by zero9178). Repository: rG LLVM Github

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

rnk accepted this revision. rnk added a comment. lgtm Comment at: clang/test/CodeGen/pr52782-stdcall-func-decl.cpp:10 +class nsICanvasRenderingContextInternal { + NS_IMETHOD_(nsresult) InitializeWithDrawTarget(NotNull); +} nsTBaseHashSet; rnk wrote: > Please

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 updated this revision to Diff 397524. zero9178 added a comment. Update test according to reviewers comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 Files: clang/lib/AST/Mangle.cpp

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

rnk added a comment. > clang actually refuses taking the address of a stdcall function if it has an > incomplete type parameter: I was going to say, I thought I remembered fixing this problem, and I guess that's how I fixed it: with errors. MSVC doesn't add stdcall mangling suffixes to

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. In D116020#3218453 , @majnemer wrote: > I wonder if we should have different behavior for MSVC targets. > > If I do: > > class Incomplete; > extern "C" int __stdcall Fn(int, Incomplete, long long); > auto fnptr = > > MSVC

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

majnemer added a comment. I wonder if we should have different behavior for MSVC targets. If I do: class Incomplete; extern "C" int __stdcall Fn(int, Incomplete, long long); auto fnptr = MSVC generates: EXTRN _Fn@12:PROC It appears that they skip over incomplete types. Should the

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, the change seems sensible to me. But I’d prefer if you could hold off pushing it for another couple days, as others who might want to comment might not be following during the

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. Friendly bump :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 created this revision. zero9178 added reviewers: mstorsjo, rnk. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stdcall name mangling requires a suffix with the number equal to the sum of the byte count of all parameter