[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-24 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid abandoned this revision. yodaldevoid added a comment. In D116229#3209414 , @owenpan wrote: > In D116229#3208507 , @curdeius > wrote: > >> Why this option is useful? Why would someone want to have a

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D116229#3208507 , @curdeius wrote: > Why this option is useful? Why would someone want to have a different > alignment in casts than in other places? > As such I'm opposed to introducing one more option. Is there any well >

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Why this option is useful? Why would someone want to have a different alignment in casts than in other places? As such I'm opposed to introducing one more option. Is there any well established code style that has something like this? Repository: rG LLVM Github

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3045 +// parenthesis of a cast we know we are in a cast. +if (!Left.isOneOf(TT_PointerOrReference, tok::l_paren)) + for (const FormatToken *Tok = What are

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid updated this revision to Diff 396062. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116229/new/ https://reviews.llvm.org/D116229 Files: clang/include/clang/Format/Format.h

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I personally prefer that pointers are aligned to the right