[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

dblaikie added a comment. In D116313#3222508 , @hans wrote: > In D116313#3218224 , @aganea wrote: > >> I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at >> least? (or maybe enable it through

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

hans added a comment. In D116313#3218224 , @aganea wrote: > I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at > least? (or maybe enable it through cmake, if ever there's a setting to detect > we're running as a bot) > Or just rever

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a subscriber: dblaikie. aganea added a comment. I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at least? (or maybe enable it through cmake, if ever there's a setting to detect we're running as a bot) Or just reverse the default setting on the main branch, ie. m

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe32936aef4a2: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://reviews.llvm.org/D116313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://reviews.llvm.org/D116313 ___ cfe

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h:34 +#endif #include +#ifdef __clang__ hans wrote: > I thought this warning should be suppressed for system headers. Isn't that > working here? Good point, because it was

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea updated this revision to Diff 397069. aganea marked 2 inline comments as done. aganea added a comment. Herald added subscribers: hiraditya, mgorny. As suggested by @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://revie

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:54 +#endif #include "MSVCSetupApi.h" +#ifdef __clang__ Since it's in our repository, would it be possible to fix clang/lib/Driver/ToolChains/MSVCSetupApi.h to be warning free? If it's

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea created this revision. aganea added reviewers: mstorsjo, amccarth, hans. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When building LLVM with Clang 13.0 on Windows, I see a bunch of `-Wnon-virtual-dtor` e