OikawaKirie added a comment.
It seems that it is not committed on my behalf. Maybe you have forgotten to add
me as the author?
Sad : (
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116329/new/
https://reviews.llvm.org/D116329
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbba729af3ef8: [clang-check] Adjust argument adjusters for
clang-check to strip options… (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
OikawaKirie added a comment.
Could you please commit it on my behalf (Ella Ma )?
Thanks a lot.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116329/new/
https://reviews.llvm.org/D116329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, LG!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116329/new/
https://reviews.llvm.org/D116329
___
cfe-commits mailing list
OikawaKirie updated this revision to Diff 399841.
OikawaKirie added a comment.
Updated as suggested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116329/new/
https://reviews.llvm.org/D116329
Files:
clang/test/Tooling/clang-check-analyze-save-temps.cpp
clang/tools/clang-check/Clang
sammccall added inline comments.
Comment at: clang/tools/clang-check/ClangCheck.cpp:217
+if (!AnalyzerOutput.empty()) {
+ Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-o"));
+ Tool.appendArgumentsAdjuster(
you can pass a vector to getInse
labath resigned from this revision.
labath added a comment.
I'm sorry, but I don't feel qualified to review this. Last time I saw this file
was in 2013.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116329/new/
https://reviews.llvm.org/D116329
__
OikawaKirie created this revision.
OikawaKirie added reviewers: kbobyrev, sammccall, labath.
OikawaKirie added a project: clang.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
OikawaKirie requested review of this revision.
Herald added
