This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG49d311874edc: [clang-format] Missing space after cast in a
macro (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
MyDeveloperDay updated this revision to Diff 397473.
MyDeveloperDay added a comment.
Fix nit and add a few more tests just to be sure
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116592/new/
https://reviews.llvm.org/D116592
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unittest
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:1887
+ // parentheses, look past it as these might be chained casts.
+ if (LeftOfParens->is(tok::r_paren) && !LeftOfParens->is(TT_CastRParen)) {
if (!LeftOfParens->MatchingPar
owenpan added a comment.
LGTM except for the nit.
Comment at: clang/lib/Format/TokenAnnotator.cpp:1887
+ // parentheses, look past it as these might be chained casts.
+ if (LeftOfParens->is(tok::r_paren) && !LeftOfParens->is(TT_CastRParen)) {
if (!LeftOfParen
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116592/new/
https://reviews.llvm.org/D116592
__
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan.
MyDeveloperDay added projects: clang, clang-format.
MyDeveloperDay requested review of this revision.
https://github.com/llvm/llvm-project/issues/52979
Though SpaceAfterCStyleCast is set t
