This revision was automatically updated to reflect the committed changes.
Szelethus marked an inline comment as done.
Closed by commit rGfd8e5762f86f: [analyzer] Don't track function calls as
control dependencies (authored by Szelethus).
Changed prior to commit:
https://reviews.llvm.org/D116597
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
I'm convinced!
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1968
+static const Expr *peelOffOuterExpr(const Expr *Ex, const ExplodedNode *N) {
+
E
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: clang/lib/Analysis/CFG.cpp:5908-5909
+void CFG::dump(bool ShowColors) const { dump(LangOptions{}, ShowColors); }
+
/// print - A simple pretty printer of a CFG that outputs to an ostream.
Szelethus updated this revision to Diff 419132.
Szelethus marked an inline comment as done.
Szelethus added a comment.
Herald added a project: All.
Fixes according to reviewer comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116597/new/
https://reviews.llvm.org/D116597
Files:
steakhal added a comment.
Looks great!
Thanks for your hard work on this topic @Szelethus.
Comment at: clang/lib/Analysis/CFG.cpp:5908-5909
+void CFG::dump(bool ShowColors) const { dump(LangOptions{}, ShowColors); }
+
/// print - A simple pretty printer of a CFG that outputs
Szelethus added a comment.
Ping ^-^
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116597/new/
https://reviews.llvm.org/D116597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus updated this revision to Diff 402549.
Szelethus added a comment.
Fix tests, mention that this is purely a heuristic.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116597/new/
https://reviews.llvm.org/D116597
Files:
clang/include/clang/Analysis/CFG.h
clang/lib/Analysis/CFG
NoQ added a comment.
Interesting. Might it be that in this scenario in order to be of interest to
the user the condition value has to be trackable back to the current stack
frame?
> the popular feedback we hear from some of our users, namely that they can
> never have too much information
The
Szelethus created this revision.
Szelethus added reviewers: dkrupp, NoQ, steakhal, gamesh411, martong, balazske.
Szelethus added a project: clang.
Herald added subscribers: manas, ASDenysPetrov, donat.nagy, mikhail.ramalho,
a.sidorin, rnkovacs, szepet, baloghadamsoftware, kristof.beyls, xazax.hun.
