[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2cc6c2d0c2f: Use a sorted array instead of a map to store AttrBuilder string attributes (authored by serge-sans-paille). Herald added a subscriber:

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397831. serge-sans-paille added a comment. Minor updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

rnk added a comment. In D116599#3221724 , @nikic wrote: > LG from my side, but I'd like a second opinion for the "require LLVMContext > in AttrBuilder" part of the change, as that's the main API impact. I think every non-toy frontend for LLVM probably

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG from my side, but I'd like a second opinion for the "require LLVMContext in AttrBuilder" part of the change, as that's the main API impact. Comment at:

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397486. serge-sans-paille added a comment. Take advice into account CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

rnk added a comment. Nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

nikic added a comment. I'm generally on board with this change. After D116110 , the `AttrBuilder` is only used in situations where we actually expect all the added attributes to be converted to `Attribute`s in any case, so we don't lose anything by storing

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397298. serge-sans-paille added a comment. upload correct patch version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk, dexonsmith. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,