[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-12 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd9879d6f43: [Clang] Make Clang copy its CMake modules into the build dir (authored by awarzynski). Changed prior to commit:

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-10 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. @PeteSteinfeld , thank you for testing this change! I want to make sure that people who are just back from their breaks get a chance to take a look, so I'll wait another day or two before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-06 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Thanks for doing this! After adopting this change, I did an in tree build followed by an out of tree build -- both without creating or using the install area. Both builds were

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-06 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. For a bit of context - this came up in a discussion for https://reviews.llvm.org/D116566/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116731/new/ https://reviews.llvm.org/D116731

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-06 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski created this revision. Herald added subscribers: Chia-hungDuan, rriddle, mgorny. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. LLVM has a documented mechanism for passing configuration