[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp updated this revision to Diff 398339. carlosgalvezp retitled this revision from "[clang][Sema] Introduce support for disabling warnings in system macros" to "[clang] Introduce support for disabling warnings in system macros". carlosgalvezp added a comment. Herald added a subscriber:

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

efriedma added a comment. I'll just note here that doing this globally is likely to have unexpected results... consider, for example: #include void f() { long x = M_PI; } Currently, the implicit conversion warning points into math.h. That said, I don't see any problem with the current imp

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp added a comment. In D116833#3232739 , @efriedma wrote: > I'll just note here that doing this globally is likely to have unexpected > results... consider, for example: > > #include > void f() { long x = M_PI; } > > Currently, the implic

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks nice. I think we'll need to think carefully before changing the default here. It seems like the choice here would depend on what token the location of the diagnostic points

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4db521cea32: [clang] Introduce support for disabling warnings in system macros (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp added a comment. In D116833#3236209 , @rsmith wrote: > Thanks, this looks nice. > > I think we'll need to think carefully before changing the default here. It > seems like the choice here would depend on what token the location of the > di