[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-12 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 399341. tyb0807 marked an inline comment as done. tyb0807 added a comment. Removed checks that set HBC flag based on the target architecture and unset it if command line explicitly disables it. This is because HBC feature does not require any new intrinsic in

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-12 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675 + HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || +ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; + + // Check features that a

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-12 Thread Son Tuan Vu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tyb0807 marked an inline comment as done. Closed by commit rG2db4cf5962de: clang support for Armv8.8/9.3 HBC (authored by tmatheson, committed by tyb0807). Repository:

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 created this revision. Herald added subscribers: hiraditya, kristof.beyls. tyb0807 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces clang command line support for new Armv8.8-A and Armv9.3-A Hinted C

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398623. tyb0807 edited the summary of this revision. tyb0807 added a comment. Remove Change-Id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basi

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398624. tyb0807 edited the summary of this revision. tyb0807 added a comment. Add more context to the patch summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Fi

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398638. tyb0807 added a comment. Support for MOPS extension should be committed in a separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398693. tyb0807 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398697. tyb0807 added a comment. Update patch author in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 updated this revision to Diff 398698. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update patch author in commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 F

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

2022-01-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666-675 + HasHBC |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || +ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; + + // Check features that are manually disabled by command li