gribozavr2 added a comment.
> Why does it matter what version outside users are using -- these are clang
> unit-tests, not a public API, right?
clang/unittests/Analysis/FlowSensitive/TestingSupport.h is a public API for
writing tests for dataflow analyses.
Repository:
rG LLVM Github Monorep
jyknight added a comment.
Herald added a subscriber: steakhal.
> Users outside of the clang repo may use different googletest versions.
I don't understand what that means.
Why does it matter what version outside users are using -- these are clang
unit-tests, not a public API, right?
Repositor
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG875117ae7a21: [clang][dataflow] Remove TestingSupport's
dependency on gtest (authored by ymandel).
Changed prior to commit:
https://reviews.llvm.o
ymandel updated this revision to Diff 400543.
ymandel added a comment.
remove redundant assert.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117304/new/
https://reviews.llvm.org/D117304
Files:
clang/unittests/Analysis/FlowSensitive/MultiVarCons
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:144
+ auto *Lattice =
+ llvm::any_cast(&State.Lattice.Value);
+
ymandel created this revision.
ymandel added a reviewer: gribozavr2.
ymandel requested review of this revision.
Herald added a project: clang.
Users outside of the clang repo may use different googletest versions. So, it's
better not to depend on llvm's googletest. This patch removes the dependenc
