[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 updated this revision to Diff 401209. njames93 added a comment. Remove now unnecessary changes in ClangTidyModule. Fix Cache miss reporting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ https://reviews.llvm.org/D117529 Files:

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 updated this revision to Diff 401197. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ https://reviews.llvm.org/D117529 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h clang-to

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

sammccall added a comment. Happy to take a look at this, but is there a particular motive for optimizing this? Looking at some profiles this appears to be something like 0.1-0.5ms in fairly complex configurations. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:289 +// nec

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 added a comment. In D117529#3251949 , @carlosgalvezp wrote: > Haven't looked much in detail so apologies if my comment is stupid - can't > CachedGlobList be used for this purpose? Should be a one-liner change I think. Not a stupid question, bu

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

carlosgalvezp added a comment. Haven't looked much in detail so apologies if my comment is stupid - can't CachedGlobList be used for this purpose? Should be a one-liner change I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ http

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 updated this revision to Diff 400893. njames93 added a comment. Herald added a subscriber: carlosgalvezp. Pre-allocate both vectors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ https://reviews.llvm.org/D117529 Files: clang-

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Build a fast factory