[PATCH] D117549: [clangd] Sort targets before printing for tests

2022-01-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcae932b6c6d3: [clangd] Sort targets before printing for tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D117549: [clangd] Sort targets before printing for tests

2022-01-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 401178. kadircet marked an inline comment as done. kadircet added a comment. - Store in vector and sort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117549/new/ https://reviews.llvm.org/D117549 Files: clan

[PATCH] D117549: [clangd] Sort targets before printing for tests

2022-01-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:1174 bool First = true; + if (!R.Targets.empty()) { +const auto &SM = R.Targets.front()->getASTConte

[PATCH] D117549: [clangd] Sort targets before printing for tests

2022-01-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Targets are not necessa