[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer Review please :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 406443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 405775. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer Any feedback please? thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 404587. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 403370. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 403354. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3262595 , @zahiraam wrote: > @majnemer > > I did take an example completely different with no use of the constexpr in > order to understand (at least for me) when the _imp prefix is generated with > CL. > This is

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer I did take an example completely different with no use of the constexpr in order to understand (at least for me) when the _imp prefix is generated with CL. This is sample.cpp: #include __declspec(dllexport) void PrintHello() { std::cout << "hello" <<

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3259928 , @majnemer wrote: > Your example is different from mine as it nests the constexpr variable inside > the function rather than having it at translation-unit scope. And I suppose we are interested in the

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added a comment. Your example is different from mine as it nests the constexpr variable inside the function rather than having it at translation-unit scope. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3259255 , @majnemer wrote: > In D117569#3258307 , @zahiraam > wrote: > >> In D117569#3257121 , @majnemer >> wrote: >> >>> I have a

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added a comment. In D117569#3258307 , @zahiraam wrote: > In D117569#3257121 , @majnemer > wrote: > >> I have a question regarding how this work with respect to the dllimport >> semantics known by the

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 401644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3257121 , @majnemer wrote: > I have a question regarding how this work with respect to the dllimport > semantics known by the linker. > IIUC, we will now allow a program like: > > extern int __declspec(dllimport)

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/test/CodeGenCXX/dllimport.cpp:2 // RUN: %clang_cc1 -disable-noundef-analysis -triple i686-windows-msvc -fno-rtti -fno-threadsafe-statics -fms-extensions -emit-llvm -std=c++1y -O0 -o - %s -DMSABI -w | FileCheck

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2219 + Info.getLangOpts().CPlusPlus && !isForManglingOnly(Kind) && + Var->hasAttr()) // FIXME: Diagnostic! The summary and the bug both mention dllimport

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer requested changes to this revision. majnemer added a comment. This revision now requires changes to proceed. I have a question regarding how this work with respect to the dllimport semantics known by the linker. IIUC, we will now allow a program like: extern int __declspec(dllimport)

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 401415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam created this revision. zahiraam added reviewers: JVApen, rsmith. zahiraam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for issue https://github.com/llvm/llvm-project/issues/53182 Repository: rG LLVM Github Monorepo