[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone added a comment. In D117603#3292657 , @var-const wrote: > @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in > libc++? (see >

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

var-const added a comment. @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in libc++? (see https://github.com/llvm/llvm-project/blob/167b623a6af26802af47f455aaa3806faaa9da9e/libcxx/include/__concepts/class_or_enum.h#L28-L30) Repository: rG LLVM Github Monorepo

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0185ffaec3c: [clang] Dont typo-fix an expression in a SFINAE context. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404381. Quuxplusone added a comment. Poke CI (clang-format failed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117603/new/ https://reviews.llvm.org/D117603 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaExprMember.cpp

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404343. Quuxplusone added a comment. Move the regression test to clang/test/SemaTemplate/, alongside the one for D118552 . Also, make it test the error message wording. CHANGES SINCE LAST ACTION

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404341. Quuxplusone added a comment. It seems like we need `tryToRecoverWithCall` to always identify a diagnostic explaining the problem, so just short-circuit-returning `ExprError()` with no diagnostic is not acceptable. Let's try this version instead.

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

ChuanqiXu added a comment. The problem looks similar with what we met in: https://github.com/llvm/llvm-project/issues/52909#issuecomment-1021631943 Maybe both of the problem could be solved at the same time. > Anyone see how this patch might have caused a placeholder type to survive > into

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone reopened this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. I'm not sure if this caused https://lab.llvm.org/buildbot/#/builders/60/builds/6350 https://lab.llvm.org/buildbot/#/builders/119/builds/7433 but I'm acting as if it did. Anyone see

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

This revision was automatically updated to reflect the committed changes. Closed by commit rG9be5f4d5afd9: [clang] Dont typo-fix an expression in a SFINAE context. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. go for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117603/new/ https://reviews.llvm.org/D117603

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone added reviewers: ChuanqiXu, urnathan, hokein, dblaikie. Quuxplusone added a comment. Add some more reviewers who've touched SemaCXX recently. Ping! If no objections are forthcoming, I'd like to land this on Friday morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 401652. Quuxplusone added a comment. Clang-formatted. @mizvekov or @rsmith: ping? I'd like to get this in before Feb 1, which is the release/14.x branch date AFAIK; because it affects workarounds in libc++ and thus makes a difference whether we will be

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone created this revision. Quuxplusone added reviewers: ldionne, rsmith, leonardchan, mizvekov. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. If this is a SFINAE context, then continuing to look up names (in