[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder closed this revision. tbaeder added a comment. I screwed up using the right Differential Revision link, but this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 ___

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

expnkx reopened this revision. expnkx added a comment. This revision is now accepted and ready to land. This patch is simply wrong. cqwrteur@Home-Server:~/fast_io_cleanup/fast_io/examples/0001.helloworld$ clang++ -o helloworld helloworld.cc -Ofast -std=c++2b -s -flto -fuse-ld=lld --target=wasm3

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added a comment. In D117888#3290628 , @sbc100 wrote: > Great! Thanks for working on this.I'm curious what toolchain you are > working that uses GNU libstdc++? I'm looking at libstdc++ enablement in a wasm/emscripten toolchain, so nothing

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5787a0c6cc4: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Great! Thanks for working on this.I'm curious what toolchain you are working that uses GNU libstdc++? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 405156. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > > > Just early ret

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404935. tbaeder marked an inline comment as done. tbaeder added a comment. Stop hardcoding `v1` or `11` and make the tests work like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? tbaeder wrote: > sbc100 wrote: > > Just early return here if no headers can be found? Looking at Gnu.cpp it >

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445 addSystemInclude(DriverArgs, CC1Args, - getDriver().SysRoot + "/include/c++/v1"); + getDriver().SysRoo

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445 addSystemInclude(DriverArgs, CC1Args, - getDriver().SysRoot + "/include/c++/v1"); + getDriver().SysRoot + "/include/c++/11"); +break; ---

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > >

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404849. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test/Driver/wasm-toolchain.cpp Index: clang/t

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; tbaeder wrote: > sbc100 wrote: > > Where does `11` com

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > Where does `11` come from here? Do o

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; Where does `11` come from here? Do other drivers hard

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

dschuff added a comment. I haven't reviewed this yet, but since we got one of these before and never merged it (https://reviews.llvm.org/D101464) we should probably land one of these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ http

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder created this revision. tbaeder added reviewers: sbc100, dlj, aheejin, sunfish. Herald added subscribers: jgravelle-google, dschuff. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The WebAssembly toolchain currently supports