This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG27ee91162dd3: [AIX][clang] include_next through clang
provided float.h (authored by daltenty).
Changed prior to commit:
https://reviews.llvm.org/D
daltenty updated this revision to Diff 404083.
daltenty added a comment.
Use more unique macro name
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117935/new/
https://reviews.llvm.org/D117935
Files:
clang/lib/Headers/float.h
clang/test/Headers/Inputs/include/float.h
clang/test/Hea
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM with minor comment.
Comment at: clang/test/Headers/Inputs/include/float.h:2
+#pragma once
+#define FLOAT_LOCAL_DEF 1
Min
daltenty updated this revision to Diff 402720.
daltenty added a comment.
Address review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117935/new/
https://reviews.llvm.org/D117935
Files:
clang/lib/Headers/float.h
clang/test/Headers/Inputs/include/float.h
clang/test/Header
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Headers/float.h:40-41
# undef LDBL_MANT_DIG
-# if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__) || __cplusplus
>= 201103L
+#if __STDC_VERSION__ >= 199901L || !defined(__STRICT_ANSI__) ||
hubert.reinterpretcast added a comment.
More comments may follow, but didn't want to delay the first one.
Comment at: clang/lib/Headers/float.h:20-21
*/
-#if (defined(__APPLE__) || (defined(__MINGW32__) || defined(_MSC_VER))) && \
-__STDC_HOSTED__ && __has_include_next()
hubert.reinterpretcast updated this revision to Diff 402156.
hubert.reinterpretcast edited the summary of this revision.
hubert.reinterpretcast added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Refresh with full context
Repository:
rG LLVM Github Monorepo
