[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-25 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ad19a833177: [CUDA,NVPTX] Corrected fragment size for tf32 LD B matrix. (authored by JackAKirk, committed by tra). Repository: rG LLVM Github Mon

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-25 Thread Jack Kirk via Phabricator via cfe-commits
JackAKirk added a comment. In D118023#3267271 , @tra wrote: > The patch uses a `@gmail.com` email. Should I change it to `JackAKirk > ` to match the sign-off email? Ah yes thanks for catching that. Please use `JackAKirk `. Repository: rG LLVM Gith

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. The patch uses a `@gmail.com` email. Should I change it to `JackAKirk ` to match the sign-off email? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023 _

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Jack Kirk via Phabricator via cfe-commits
JackAKirk added a comment. In D118023#3266987 , @tra wrote: > If you are not sure if you have commit access, you probably do not. It must > be explicitly granted: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > > As for landing the

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. If you are not sure if you have commit access, you probably do not. It must be explicitly granted: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access As for landing the patch, I do it manually with git. Never tried it with `arc`, so I can't say much, except

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Jack Kirk via Phabricator via cfe-commits
JackAKirk added a comment. In D118023#3266877 , @tra wrote: > LGTM. Should I commit the patch on your behalf? > > In D118023#3265601 , @JackAKirk > wrote: > >> Note that the test, llvm/test/CodeGen/NVPTX/wmma.py

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Should I commit the patch on your behalf? In D118023#3265601 , @JackAKirk wrote: > Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had t

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Jack Kirk via Phabricator via cfe-commits
JackAKirk added a comment. Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct value already but didn't seem to cover the mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

2022-01-24 Thread Jack Kirk via Phabricator via cfe-commits
JackAKirk created this revision. JackAKirk added a reviewer: tra. JackAKirk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: JackAKirk Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118023 Files: clang/