[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ce45670789: [clang] Correctly(?) handle placeholder types in ExprRequirements. (authored by arthur.j.odwyer). Repository: rG LLVM Github

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 ___ cfe-commits mailing list

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404624. Quuxplusone added a comment. Update another single-line `if` too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404621. Quuxplusone added a comment. Update assert style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3373 ASTContext::getLValueReferenceType(QualType T, bool SpelledAsLValue) const { - assert(getCanonicalType(T) != OverloadTy && - "Unresolved overloaded function type"); + if

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

urnathan added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3373 ASTContext::getLValueReferenceType(QualType T, bool SpelledAsLValue) const { - assert(getCanonicalType(T) != OverloadTy && - "Unresolved overloaded function type"); + if

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added a comment. Gentle ping! (@ChuanqiXu @urnathan perhaps?) I'm hoping to land D118552 followed by a re-land of D117603 , this week and //ideally// tomorrow. :) CHANGES SINCE LAST ACTION

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404380. Quuxplusone added a comment. Poke CI (clang-format failed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3375 +assert(T->isSpecificPlaceholderType(BuiltinType::UnknownAny) && "Unresolved placeholder type"); + } Quuxplusone wrote: > Btw, I strongly suspect that the presence of

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

rjmccall added a comment. It's a type that the debugger integration uses when it doesn't know the type of a symbol. If it's a data symbol, you make a `VarDecl` with `UnknownAny` type; if it's a function symbol, you make a `FunctionDecl` with `UnknownAny`. In either case, if the user fails to

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added a subscriber: rjmccall. Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3375 +assert(T->isSpecificPlaceholderType(BuiltinType::UnknownAny) && "Unresolved placeholder type"); + } Btw, I strongly suspect that

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone created this revision. Quuxplusone added reviewers: ChuanqiXu, saar.raz, rsmith. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. PR52905 was originally papered over in a different way, but I believe this is