pcc added inline comments.
Comment at: test/CodeGen/cfi-icall.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall
-fsanitize-trap=cfi-icall -emit-llvm -o - %s | FileCheck --check-prefix=ITANIUM
%s
+// RUN: %clang_cc1 -triple x86_64-pc-windows-msv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247238: CFI: Introduce -fsanitize=cfi-icall flag. (authored
by pcc).
Changed prior to commit:
http://reviews.llvm.org/D11857?vs=33175&id=34403#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11857
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM with a nit
Comment at: test/CodeGen/cfi-icall.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall
-fsanitize-trap=cfi-icall -emit-llvm -o - %s
pcc updated this revision to Diff 33175.
pcc added a comment.
- Add apology for lack of documentation
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMa
pcc added inline comments.
Comment at: docs/ControlFlowIntegrity.rst:149
@@ +148,3 @@
+shared library boundaries are handled as if the callee was not compiled with
+``-fsanitize=cfi-icall``.
+
kcc wrote:
> mention that LTO is require explicitly?
Done above.
http
pcc updated this revision to Diff 33020.
pcc added a comment.
- Address comment
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGClass
kcc added inline comments.
Comment at: docs/ControlFlowIntegrity.rst:149
@@ +148,3 @@
+shared library boundaries are handled as if the callee was not compiled with
+``-fsanitize=cfi-icall``.
+
mention that LTO is require explicitly?
http://reviews.llvm.org/D1185
pcc updated this revision to Diff 32179.
pcc added a comment.
Rebase onto http://reviews.llvm.org/D12038
http://reviews.llvm.org/D11857
Files:
docs/ControlFlowIntegrity.rst
include/clang/AST/Mangle.h
include/clang/Basic/Sanitizers.def
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.
pcc added a comment.
> The documentation would probably benefit from some advice about when to use
> each and how they compare.
Added.
Comment at: lib/AST/ItaniumMangle.cpp:4119-4126
@@ +4118,10 @@
+raw_ostream &Out) {
+ if
pcc updated this revision to Diff 31871.
pcc added a comment.
- Create distinct MDNodes for types with internal linkage; replace custom bit
set mangling with mangleTypeName throughout
- Add documentation explaining the difference between this and
-fsanitize=function
http://reviews.llvm.org/D11
samsonov added a comment.
Driver changes look good.
http://reviews.llvm.org/D11857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
This seems to have a lot of overlap with the function sanitizer. The
documentation would probably benefit from some advice about when to use each
and how they compare.
Comment at: lib/AST/ItaniumMangle.cpp:4119-4126
@@ +4118,10 @@
+
12 matches
Mail list logo
