[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3fcfcb9464b: [C++20][Modules][7/8] Find the primary interface name for a module. (authored by iains). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 411546. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/lib/Sema/SemaModule.cpp Ind

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 410539. iains added a comment. rebased, addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/li

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:527 +} +return StringRef(Name); + } Here we could return `Name` simply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Na

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 409666. iains marked an inline comment as done. iains added a comment. remove stray blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/cl

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 409665. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/lib/S

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added a comment. My implementation is StringRef getPrimaryModuleName() const { if (Check Kind) return Name; return StringRef(Name).split('-').first; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ ht

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; iains wrote: > urna

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; urnathan wrote: > h

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:522 + + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); Is it possible to return a StringRef rather than a copy? Repository:

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:520-522 + /// Get the primary module interface name from a partition. + + std::string getPrimaryModuleInterfaceName() const { stray blank line? Comment at: clang/i