iains updated this revision to Diff 409178.
iains marked 2 inline comments as not done.
iains added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118893/new/
https://reviews.llvm.org/D118893
Files:
clang/inclu
ChuanqiXu added a comment.
BTW, I guess it would be helpful to add the index in the series in the title.
Like `[C++20][Modules] Track valid import state (1/8)`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118893/new/
https://reviews.llvm.org/D11
ChuanqiXu added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543
+def err_import_not_allowed_here : Error<
+ "imports must be contiguous and immediately follow the module declaration">;
+def err_import_in_global_fragment : Error<
--
urnathan added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543
+def err_import_not_allowed_here : Error<
+ "imports must be contiguous and immediately follow the module declaration">;
+def err_import_in_global_fragment : Error<
---
iains added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543
+def err_import_not_allowed_here : Error<
+ "imports must be contiguous and immediately follow the module declaration">;
+def err_import_in_global_fragment : Error<
u
urnathan added a comment.
Looks right to me -- I also implemented such a state machine in GCC's parser.
There are a bunch of formatting issues to fix of course.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543
+def err_import_not_allowed_here : Error<
+ "im
iains created this revision.
iains updated this revision to Diff 408755.
iains added a comment.
iains added reviewers: rsmith, urnathan, ChuanqiXu.
iains updated this revision to Diff 408803.
iains published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-com
