durin42 created this revision.
Herald added a subscriber: jdoerfert.
durin42 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
LLVM is growing knowledge of this, so we should inform it when we have
the information available.
Depends on D1182
xbolva00 added inline comments.
Comment at: clang/test/CodeGen/alloc-align-attr.c:14
// CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64
// CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64
[[CASTED_ALIGN]]) ]
// CHECK-NEXT:[[TMP1:%
durin42 added inline comments.
Comment at: clang/test/CodeGen/alloc-align-attr.c:14
// CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64
// CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64
[[CASTED_ALIGN]]) ]
// CHECK-NEXT:[[TMP1:%.
jyknight added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:4605
+ TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) {
+llvm::AttributeList NewAttrs = Attrs;
+if (AA)
We do need to fallback to an assume for
"if(CGF.SanOpts.has(Sa
durin42 added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:4605
+ TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) {
+llvm::AttributeList NewAttrs = Attrs;
+if (AA)
jyknight wrote:
> We do need to fallback to an assume for
> "if
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 408019.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-al
durin42 updated this revision to Diff 408097.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
durin42 updated this revision to Diff 408116.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
durin42 updated this revision to Diff 410058.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
durin42 updated this revision to Diff 410558.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
jyknight added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:4605
+ TryEmitAsCallSiteAttribute(const llvm::AttributeList &Attrs) {
+llvm::AttributeList NewAttrs = Attrs;
+if (AA)
durin42 wrote:
> jyknight wrote:
> > We do need to fallback to
durin42 updated this revision to Diff 410896.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
12 matches
Mail list logo