durin42 added a comment.
FYI: this is ready for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
durin42 updated this revision to Diff 529616.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-align-attr.c
clang/test/CodeGen/alloc-fns-ali
durin42 updated this revision to Diff 529447.
durin42 requested review of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
https://reviews.llvm.org/D119271
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/alloc-alig
lebedev.ri resigned from this revision.
lebedev.ri added a comment.
Herald added a subscriber: StephenFan.
This review may be stuck/dead, consider abandoning if no longer relevant.
Removing myself as reviewer in attempt to clean dashboard.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
durin42 planned changes to this revision.
durin42 added a comment.
I have some reworking to do on this after my latest round of llvm-side work
that I'll try and get out later this week.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119271/new/
htt
lebedev.ri added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
jyknight added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
lebedev.ri added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
durin42 added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
lebedev.ri added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
durin42 added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNMENT_ADDR]], align 8
- // CHECK-NEXT:
lebedev.ri added a reviewer: lebedev.ri.
lebedev.ri added inline comments.
Comment at:
clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55
// CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64,
i64* %[[ALIGNME
durin42 retitled this revision from "CGCall: also emit LLVM `allocalign`
attribute when handling AllocAlign" to "clang: emit allocalign to LLVM for
alloc_align attributes".
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 415230.
Herald added a project: All.
Rep
13 matches
Mail list logo