[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb96106af3f55: [AArch64][ARM] add -Wunaligned-access only for clang (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407571. ychen added a comment. - Remove `CmdArgs` from `arm::getARMTargetFeatures` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files:

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Ah, I see. Please can you also remove the `CmdArgs` parameter from `arm::getARMTargetFeatures` when you commit this? This would be useful, along with a comment at the top of

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407336. ychen added a comment. - Handle ARM - Add driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407314. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309253 , @ychen wrote: > In D119301#3309140 , @lenary wrote: > >> I don't fully understand the reasoning for the patch, and you haven't really >> explained it. I think what you

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407313. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309140 , @lenary wrote: > I don't fully understand the reasoning for the patch, and you haven't really > explained it. I think what you are saying is that the `IsAux` argument to > `getTargetFeatures` should be

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407308. ychen added a comment. - add ARM64 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

lenary added a comment. I don't fully understand the reasoning for the patch, and you haven't really explained it. I think what you are saying is that the `IsAux` argument to `getTargetFeatures` should be considered because it's `true` for offloading to another compiler, but I don't understand

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen created this revision. ychen added reviewers: mubashar_, lenary, pbarrio. Herald added a subscriber: kristof.beyls. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo