This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c7e6fc7b665: [clang-format] Do not remove required spaces
when aligning tokens. (authored by curdeius).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119419
curdeius updated this revision to Diff 407442.
curdeius marked 3 inline comments as done.
curdeius added a comment.
Address review comments. Add a fixme note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119419/new/
https://reviews.llvm.org/D11941
owenpan accepted this revision.
owenpan added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Format/WhitespaceManager.cpp:407
+// We should not remove required spaces unless we break the line before.
+assert(Changes[i].NewlinesBefo
curdeius added inline comments.
Comment at: clang/lib/Format/WhitespaceManager.cpp:334-337
+ if (Changes[i].NewlinesBefore == 0)
+Changes[i].Spaces =
+std::max(Changes[i].Spaces,
+ static_cast(Changes[i].Tok->SpacesRequiredBefore));
--
curdeius created this revision.
curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan.
curdeius requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues/44292.
Fixes https://github.co
