JonasToth added a comment.
Sorry for the long delay, i simply forgot.
The patch is commited! :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3f0f20366622: run-clang-tidy: Fix infinite loop on windows
(authored by JonasToth).
Herald added a project: All.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
Febbe added a comment.
@salman-javed-nz you're welcome, I only fixed it because I saw the bug in the
trace directly. Normally, I would only fix C/C++ stuff :D.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
__
Febbe added a comment.
@JonasToth yes, it would be nice, to test this and then push it for me. Also a
backport to 14.0 would be good :).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
___
cfe-commi
Febbe updated this revision to Diff 411606.
Febbe added a comment.
Applied the feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
Files:
clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
Index: clang-tools-extra/clang-tidy/tool/run
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:69
while not os.path.isfile(os.path.join(result, path)):
-if os.path.realpa
salman-javed-nz added a comment.
Just a drive-by comment to say, thank you for taking the time to make this fix.
It's a bug I've triggered many times. Great to see it being resolved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https:
Febbe added a comment.
I don't think I have commit rights, so someone of you also have to commit this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
___
cfe-c
Febbe added a comment.
Currently, only tested on Windows.
This should also increase performance, since the path is canonicalized only
once.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119481/new/
https://reviews.llvm.org/D119481
__
Febbe created this revision.
Herald added a subscriber: carlosgalvezp.
Febbe requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D119481
Files:
clang-tools-extra/cla
10 matches
Mail list logo