[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

asb added a comment. In D119541#3940597 , @arichardson wrote: > I just noticed that target features (e.g. -mrelax) are broken in all LLVM 14 > releases due to D113336 . This should have > been cherry-picked back tot t

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

arichardson added a comment. Herald added subscribers: sunshaoce, StephenFan, shiva0217. Herald added a project: All. I just noticed that target features (e.g. -mrelax) are broken in all LLVM 14 releases due to D113336 . This should have been cherry-picked back

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + rogfer01

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

rogfer01 added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + I think we may be missing are missing a `RUN`

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f51a9e2730e: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD updated this revision to Diff 407852. eopXD added a comment. Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-defaul

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-isa features back after implication

eopXD created this revision. eopXD added reviewers: junparser, craig.topper, asb, frasercrmck. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMo