This revision was automatically updated to reflect the committed changes.
Closed by commit rG985888411da9: [analyzer] Refactor makeNull to
makeNullWithWidth (NFC) (authored by vabridgers, committed by einvbri
vince.a.bridg...@ericsson.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
NoQ accepted this revision.
NoQ added a comment.
All clear now. Amazing, thank you for your detailed response, I've corrected my
understanding of address spaces so I'll be able to understand future patches
better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vabridgers added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378
+type = type->isReferenceType()
+ ? Context.getPointerType(type->getPointeeType())
+ : type;
vabridgers wrote:
vabridgers updated this revision to Diff 416735.
vabridgers marked an inline comment as not done.
vabridgers added a comment.
add updated test cases per comments from NoQ
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
vabridgers added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378
+type = type->isReferenceType()
+ ? Context.getPointerType(type->getPointeeType())
+ : type;
NoQ wrote:
>
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378
+type = type->isReferenceType()
+ ? Context.getPointerType(type->getPointeeType())
+ : type;
vabridgers wrote:
> NoQ
vabridgers added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378
+type = type->isReferenceType()
+ ? Context.getPointerType(type->getPointeeType())
+ : type;
NoQ wrote:
> How
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378
+type = type->isReferenceType()
+ ? Context.getPointerType(type->getPointeeType())
+ : type;
How do you discover the
steakhal added a comment.
Land it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
https://reviews.llvm.org/D119601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vabridgers added a comment.
Is it ok to land this change? Or shall we continue to wait on @NoQ ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
https://reviews.llvm.org/D119601
___
vabridgers marked an inline comment as done.
vabridgers added a comment.
Herald added a project: All.
@NoQ - ping!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
https://reviews.llvm.org/D119601
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
I'm satisfied. I cannot see any issues.
AFAI remember the tests runs uncovered no report changes - as expected from an
NFC change.
So it's good to go on my part.
Wait for a review from
vabridgers marked an inline comment as done.
vabridgers added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:372
- Loc makeNull() {
-return loc::ConcreteInt(BasicVals.getZeroWithPtrWidth());
}
steakhal
vabridgers updated this revision to Diff 409896.
vabridgers added a comment.
refactor based on @steakhal comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
https://reviews.llvm.org/D119601
Files:
steakhal added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:368
Loc makeNullWithType(QualType type) {
-return loc::ConcreteInt(BasicVals.getZeroWithTypeSize(type));
- }
-
- Loc makeNull() {
-return
15 matches
Mail list logo
