[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire updated this revision to Diff 420384. junaire added a comment. Wording issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

aaron.ballman added a comment. In D119609#3426279 , @erichkeane wrote: > I think LGTM on technical perspective, Please don't commit until > @aaron.ballman confirms he is OK with the direction, or would like to wait > longer for GCC. I spotted some tec

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire updated this revision to Diff 420178. junaire retitled this revision from " [Clang][Sema] Prohibit expr statement in the default argument" to "[Clang][Sema] Prohibit expr statement in the default argument". junaire edited the summary of this revision. junaire added a comment. Add tests f

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think LGTM on technical perspective, Please don't commit until @aaron.ballman confirms he is OK with the direction, or would like to wait longer for GCC. Comment a

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:10 + + void fn(int i, int j = ({{}, {}, {,}}), int k = ""); // expected-error {{expression statement not permitted in default argument}} expected-error {{cannot initialize a parameter o

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

erichkeane added a comment. In D119609#3424434 , @junaire wrote: > Hi @aaron.ballman, do you think it's time to consider reviewing this? > > I don't why there's no response or progress in GCC, but I think I can submit > a patch for them if they think thi

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire added a comment. Hi @aaron.ballman, do you think it's time to consider reviewing this? I don't why there's no response or progress in GCC, but I think I can submit a patch for them if they think this issue is low prior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION