[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 408876. jansvoboda11 added a comment. Move `SearchDirIdx::get()` to `HeaderSearch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119825/new/ https://reviews.llvm.org/D119825 Files:

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:185 + /// Get search directory stored at the index. + DirectoryLookup (HeaderSearch ) const; +}; ahoppen wrote: > I would have expected these to be methods on

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

2022-02-15 Thread Alex Hoppen via Phabricator via cfe-commits
ahoppen added a comment. Definitely a lot nicer  Comment at: clang/include/clang/Lex/HeaderSearch.h:185 + /// Get search directory stored at the index. + DirectoryLookup (HeaderSearch ) const; +}; I would have expected these to be methods on `HeaderSearch`.

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. Herald added a subscriber: arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces new `SearchDirIndex`