[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9a7fdd6a8a: [clang-format] Fixed handling of requires clauses followed by attributes (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius accepted this revision. curdeius added a comment. In D119893#3326247 , @HazardyKnusperkeks wrote: > Formatting Test added. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 __

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409237. HazardyKnusperkeks added a comment. Formatting Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/Form

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius accepted this revision. curdeius added a comment. LGTM. Maybe you can add a minimal test in `FormatTest.cpp` though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 ___ cfe-commits mailing l

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

JohelEGP accepted this revision. JohelEGP added a comment. This revision is now accepted and ready to land. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 ___ cfe-commits mailing list cfe

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409195. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a reviewer: Quuxplusone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLi

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius added a comment. In D119893#3325432 , @HazardyKnusperkeks wrote: > In D119893#3325375 , @curdeius > wrote: > >> +1 to Arthur's comments. >> Does it fix any of the recently created issues? > > Yeah, I sh

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks added a comment. In D119893#3325375 , @curdeius wrote: > +1 to Arthur's comments. > Does it fix any of the recently created issues? Yeah, I should have put that in the commit message, right? ;) Maybe I would have discovered the bug my

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius added a comment. +1 to Arthur's comments. Does it fix any of the recently created issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 ___ cfe-commi

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

Quuxplusone added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3018-3019 do { +bool LambdaThisTimeAllowed = LambdaNextTimeAllowed; +LambdaNextTimeAllowed = false; + Nit: For this pattern, consider `bool LambdaThisTimeAllowed =

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.