Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-09-08 Thread Artem Belevich via cfe-commits
tra abandoned this revision. tra added a comment. Emitting IR is not sufficient to ensure that the kernels survive GDCE, so the patch does not work with optimizations on. http://reviews.llvm.org/D11666 would have to do for now. http://reviews.llvm.org/D11993 _

Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Eli Bendersky via cfe-commits
eliben accepted this revision. eliben added a comment. lgtm Comment at: test/CodeGenCUDA/ptx-kernels.cu:26 @@ -16,1 +25,2 @@ // CHECK: !{{[0-9]+}} = !{void ()* @global_function, !"kernel", i32 1} +// CHECK: !{{[0-9]+}} = !{void (i32)* @_Z16templated_kernelIiEvT_, !"kernel", i3

Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this. -eric http://reviews.llvm.org/D11993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: echristo, rsmith, eliben. tra added a subscriber: cfe-commits. This is a somewhat different way to do it than D11666 which got rolled back. Codegen postpones emitting instantiated kernel function template until it's used. If kernel is used only fro