[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-17 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4dde8d39a9: [clang][dataflow] Add transfer functions for logical and, or, not. (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:39 +// represent conjunctions, disjunctions, and negations. +AtomicBoolValue, +BoolConjunctionValue, xazax.hun wrote: > Do we need `Value` in the `Kind` if we

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 409330. sgatev marked 5 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119953/new/ https://reviews.llvm.org/D119953 Files: clang/in

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:28 + + /// Returns the environment of the basic block that contains `S` or nullptr if + /// there isn't one. xazax.hun wrote: > Depending on how willing sensitiv

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:28 + + /// Returns the environment of the basic block that contains `S` or nullptr if + /// there isn't one. Depending on how willing sensitive we are to memory

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 409296. sgatev added a comment. Remove unnecessary IgnoreParens calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119953/new/ https://reviews.llvm.org/D119953 Files: clang/include/clang/Analysis/FlowSensit

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

2022-02-16 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A