[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3902838 , @thakis wrote: > Great, thanks :) > > For context, we're trying to use this flag In Production to try and debug a > linker crash, but making the compiler repro failed for some reason – and then > we wondere

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. > I didn't really make a conscious decision one way or the other. I guess > reproing all jobs leading to a crash somewhat makes sense, though it also > doesn't seem that helpful to get the preprocessed source file. I'll send out > a patch to fix this Great, thanks :) F

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3902789 , @thakis wrote: > I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, > clang creates both preprocessor and linker repros: > > clang: note: diagnostic msg: > /var/folders/w6/wpbtszr

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, clang creates both preprocessor and linker repros: clang: note: diagnostic msg: /var/folders/w6/wpbtszrs7jl9dc9l5qtdkvg0gn/T/main-241332.c clang: note: diagnostic msg: /var/folders/w6/wp

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > there didn't already exist a PS4 lit feature that I could mark as unsupported. ? I believe `UNSUPPORTED: ps4` should work, because UNSUPPORTED will look at the default target triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3693458 , @probinson wrote: > There is now cross-project-tests which would seem to be the appropriate place > for a test that wants to run both clang and lld. Thanks for pointing that out. I'll look into moving the t

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1638 +llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments(); +ArgList.push_back(Saver.save(Twine{"--reproduce="} + TmpName).data()); +NewLLDInvocation.replaceArguments(std::move(ArgList

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > lld has tests for --reproduce already. Even if I added an environment > variable to crash lld, the test would depend on lld being built, adding a big > dependency to clang's tests. Do we think that's worth it? There is now cross-project-tests which would seem to be

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3692032 , @thakis wrote: > This breaks tests on mac and win: > http://45.33.8.238/macm1/41545/step_7.txt > http://45.33.8.238/win/63579/step_7.txt > > Please take a look and revert for now if it takes a while to fix.

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. This breaks tests on mac and win: http://45.33.8.238/macm1/41545/step_7.txt http://45.33.8.238/win/63579/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3691843 , @MaskRay wrote: > LGTM > > (Note: This is a patch which I think would benefit from a second look and > 2.5h from approval to push was too short for others to react on this patch.) Ack, I'll give more time i

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

MaskRay added a comment. LGTM (Note: I think 2.5h from approval to push was too short for others to react on this patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120175/new/ https://reviews.llvm.org/D120175

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fd03b00ee02: [Driver] Re-run lld with --reproduce when it crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHA