[PATCH] D120271: [Clang] Add offload kind to embedded offload object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f89769cd775: [Clang] Add offload kind to embedded offload object (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Adjust commit message. LG, we can address outstanding comments for different encodings as we go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert added a comment. Herald added a project: All. @saiislam Ok to postpone the bundle entry usage to a follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3338034 , @saiislam wrote: > Will it be possible to use Bundle Entry ID format [1] for naming sections and > being sort of the the primary key to refer an offload object? > The arch string following the triple will be

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

saiislam added a comment. Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object? The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 updated this revision to Diff 410413. jhuber6 added a comment. Updating after moving dense map implementation out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 Files: clang/lib/Driver/ToolCha

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3336277 , @jdoerfert wrote: > The failing test needs to be adjusted, right? Yes, forgot about that. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKin

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert added a comment. The failing test needs to be adjusted, right? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKind == RHS.OffloadKind && + LHS.TheTriple == RHS.TheTriple && LHS.Arch == RHS.Arch; + } --

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the offload kind to the embedded section name in preparation for offloading