This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc05da55bdf54: [clang-format] Handle trailing comment for
InsertBraces (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341
if (!L.InPPDirective) {
Tok = getLastNonComment(L);
-if (Tok)
+if (Tok) {
+ Tok = L.Tokens.back().Tok;
owenpan wrote:
> HazardyK
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341
if (!L.InPPDirective) {
Tok = getLastNonComment(L);
-if (Tok)
+if (Tok) {
+ Tok = L.Tokens.back().Tok;
HazardyKnusperkeks wrote:
owenpan updated this revision to Diff 411256.
owenpan added a comment.
- Simplified the code that backtracks to the token which the right braces are
to be inserted after.
- Added a missing newline in the new testcase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120503/new/
https://re
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2340-2341
if (!L.InPPDirective) {
Tok = getLastNonComment(L);
-if (Tok)
+if (Tok) {
+ Tok = L.Tokens.back().Tok;
So basically o
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120503/new/
https://reviews.llvm.org/D120503
__
owenpan created this revision.
owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay.
owenpan added a project: clang-format.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
http
